Fix Null Reference when Schema is null in a specific circumstance.

[ksmithRenweb]

The GetTypeName function handles a null Schema when it is passed in but the hint parameter is attempting to use the Schema assuming it is not null. This is where the NullReferenceException is generated. With a couple of extra lines of code, that case is handled.

The other option is to make the GetTypeName hint default with null and inside the method if Schema is not null but hint is null. Then do the code, "hint = !response.Value.Schema.HasTypeNameTitle ? "Response" : null"

[jeremyVignelles]

Not sure what the behavior should be here, I don't have enough context, but the change seems to improve null safety here

[RicoSuter]

I'd like to merge but there are conflicts. Can you fix those?

[ksmithRenweb]

I'd like to merge but there are conflicts. Can you fix those?

It looks like the conflicts are from equivalent code that you commited an hour before your comment. See below.
Do you prefer the more verbose style I have, or the concise style you commited?

<<<<<<< fixNullRef
                var schemaHasTypeNameTitle = response.Value.Schema?.HasTypeNameTitle;
                var hint = schemaHasTypeNameTitle != true ? "Response" : null;
                return _generator.GetTypeName(response.Value.Schema, isNullable, hint);
=======
                return _generator.GetTypeName(response.Value.Schema, isNullable, response.Value.Schema?.HasTypeNameTitle != true ? "Response" : null);
>>>>>>> master

[RicoSuter]

I think the more verbose one is better.

[ksmithRenweb]

@RicoSuter Merge conflict fixed.

[RicoSuter]

Thx.