WIP: Array parameters in URL (#3529) #3980
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We faced with the issue described in #3529 when the TypeScript client ignores the
style
attribute of a parameter passed in URL. For example, we have a schema defining input argument like this:and Swagger UI does build the URL as
xxx?eventTypes=EventA,EventB
which is exactly what we are expecting. But NSwag - both TypeScript and C# version - serializes parameters differently:xxx?eventTypes=EventA&eventTypes=EventB
and so on.I would like to contribute to the library and make necessary changes, and here is the first draft. It is not a completed work, for example, there should be additional checks for
IsDateOrDateTimeArray
. Additionally, I am going to make similar changes to C# generators and write tests. But before I spent too much time on this I wanted to get a confirmation from you that this is the right way to go.With these changes, I was able to produce such code for my TypeScript client:
style=matrix
style=form
Maybe not the best JS code I ever saw, but it seems to do what we need.
Looking forward to hearing back from you, @RicoSuter!