Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#4131 store serialized json in separate variable for easy inspection #4136

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Feature/#4131 store serialized json in separate variable for easy inspection #4136

merged 2 commits into from
Sep 16, 2022

Conversation

dlidstrom
Copy link
Contributor

This fixes #4131. The serialized content and parameters are saved in separate variables in order to make it possible to see what is sent. This adds an inspection point that was missing IMHO.

- this makes it easy to inspect what is sent
@dlidstrom dlidstrom changed the title Feature/#4131 Feature/#4131 store serialized json in separate variable for easy inspection Sep 6, 2022
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RicoSuter RicoSuter merged commit 255539b into RicoSuter:master Sep 16, 2022
@RicoSuter
Copy link
Owner

Thanks for the PR.

lahma pushed a commit to lahma/NSwag that referenced this pull request Dec 25, 2022
… easy inspection (RicoSuter#4136)

* generate json in variable

- this makes it easy to inspect what is sent

* fix test
lahma pushed a commit to lahma/NSwag that referenced this pull request Jan 20, 2024
… easy inspection (RicoSuter#4136)

* generate json in variable

- this makes it easy to inspect what is sent

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please generate json in variable instead of StringContent constructor
3 participants