Improve typescript output #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 30, 2023 17:45
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Jan 20, 2024
* Declare variables with const https://rules.sonarsource.com/javascript/RSPEC-3504/ * Unnecessary undefined optional property type https://rules.sonarsource.com/typescript/RSPEC-4782/ * Prefer nullish coalescing operator to ternary https://rules.sonarsource.com/typescript/RSPEC-6606/ * Prefer logical or operator to ternary https://rules.sonarsource.com/typescript/RSPEC-6644/ * Remove redundant undefined https://rules.sonarsource.com/typescript/RSPEC-6571/ * Remove redundant undefined from test --------- Co-authored-by: Klinkby <m@kli.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Sonar rules mentioned in commit descriptions PR improves the readability of Typescript generated from liquid templates.
Fixes #3552