Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing assignment of base URL #4691

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix missing assignment of base URL #4691

merged 1 commit into from
Jan 10, 2024

Conversation

paulomorgado
Copy link
Contributor

Fixes #4637

@paulomorgado paulomorgado mentioned this pull request Jan 7, 2024
Closed
@paulomorgado paulomorgado marked this pull request as ready for review January 8, 2024 09:33
@paulomorgado paulomorgado mentioned this pull request Jan 10, 2024
Open
@RicoSuter
Copy link
Owner

RicoSuter commented Jan 10, 2024 •
edited
Loading

Is this ready to be merged?
Will this fix #4697 as well?

@paulomorgado
Copy link
Contributor Author

Is this ready to be merged? Will this fix #4697 as well?

It validates and "corrects" the base URL, if passed as an argument. So, I hope so.

@RicoSuter RicoSuter merged commit a5b2d04 into RicoSuter:master Jan 10, 2024
1 check passed
@paulomorgado paulomorgado deleted the patch-1 branch January 11, 2024 08:53
@olegd-superoffice
Copy link
Contributor

This breaks code generation with /GenerateBaseUrlProperty:false option in v14.0.1
Here's small project which demonstrates regression: GenerateBaseUrlPropertyFalse.zip
It works with NSwag.ApiDescription.Client 13.20.0 and 14.0.0 but fails with 14.0.1

@paulomorgado
Copy link
Contributor Author

paulomorgado commented Jan 12, 2024 •
edited
Loading

@olegd-superoffice, please open an issue tagging me and provide the swagger used.

@olegd-superoffice olegd-superoffice mentioned this pull request Jan 13, 2024
Open
@soligen2010 soligen2010 mentioned this pull request Feb 9, 2024
Open
@soligen2010
Copy link

I think this PR broke BaseUrl. Please see issue #4764

@soligen2010 soligen2010 mentioned this pull request May 22, 2024
Open
lahma pushed a commit to lahma/NSwag that referenced this pull request Jun 13, 2024
@paulomorgado @lahma
Fix missing assignment of base URL (RicoSuter#4691)
76ac885 
Fixes RicoSuter#4637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSwag C# Client generation does not set BaseUrl properly
4 participants
@paulomorgado @RicoSuter @olegd-superoffice @soligen2010