Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offers - Experimental configuration #792

Closed
saubyk opened this issue Sep 6, 2021 · 0 comments · Fixed by #892
Closed

Offers - Experimental configuration #792

saubyk opened this issue Sep 6, 2021 · 0 comments · Fixed by #892
Labels
Core Lightning enhancement New feature or request Offers
Milestone
Release 0.12.0-beta

Comments

@saubyk
Copy link
Collaborator

saubyk commented Sep 6, 2021 •
edited
Loading

Configuration to enable offers

Since Offers is an experimental feature on C-Lightning, it should not be enabled as a default in the UI. The user should turn the feature ON via a setting on the Node Config page. We should create a new tab Experimental Features and enable the feature to be toggled ON/OFF there.

To educate user on offers we can provide the below information:

  • link to http://bolt12.org
  • instructions on enabling offers in C-lightning (add the experimental-offers flag in the config file)
@saubyk saubyk added Core Lightning enhancement New feature or request labels Sep 6, 2021
@saubyk saubyk added this to the Release 0.12.0-beta milestone Sep 6, 2021
@saubyk saubyk changed the title Offers UI [C-Lightning] Offers UI - Basic config and Create offer feature Sep 6, 2021
@saubyk saubyk changed the title Offers UI - Basic config and Create offer feature Offers UI - Basic config Sep 10, 2021
@saubyk saubyk changed the title Offers UI - Basic config Offers experimental configuration Sep 10, 2021
@saubyk saubyk changed the title Offers experimental configuration Offers - Experimental configuration Sep 10, 2021
@saubyk saubyk added the Offers label Sep 10, 2021
@diogorsergio diogorsergio mentioned this issue Sep 15, 2021
Open
@ShahanaFarooqui ShahanaFarooqui linked a pull request Dec 5, 2021 that will close this issue
Offers - Experimental configuration #892
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Lightning enhancement New feature or request Offers
Projects
None yet
Milestone
Release 0.12.0-beta
Development

Successfully merging a pull request may close this issue.

Offers - Experimental configuration Ride-The-Lightning/RTL
2 participants
@ShahanaFarooqui @saubyk