Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

세벌식 종성 입력 오류 #529

Closed
kiwiyou opened this issue Oct 3, 2021 · 2 comments · Fixed by #530
Closed

세벌식 종성 입력 오류 #529

kiwiyou opened this issue Oct 3, 2021 · 2 comments · Fixed by #530
Labels
bug Something isn't working D-Easy EASY T-Engine

Comments

@kiwiyou
Copy link

kiwiyou commented Oct 3, 2021

종성을 연속하여 입력할 경우 종성이 초성으로 인식되어 이후 입력한 모음과 조합됩니다.
감 + ㅁ(종성) + ㅏ 의 경우, 감ㅁㅏ가 아닌 감마가 됩니다.
세벌식 390에서 테스트하였습니다.

@kiwiyou
Copy link
Author

kiwiyou commented Oct 3, 2021

FlexibleComopseOrder, ComposeChoseongSsang 애드온을 사용중이고,
FlexibleComopseOrder 유무와는 상관없이 발생합니다.

@kiwiyou
Copy link
Author

kiwiyou commented Oct 3, 2021

match prev_jong.try_add(jong, addons) {
Some(new) => {
self.jong = Some(new);
CharacterResult::Consume
}
None => {
let new;
match jong.to_cho(addons) {
JongToCho::Direct(cho) => {
new = Self {
cho: Some(cho),
..Default::default()
};
}
JongToCho::Compose(..) => {
new = Self {
jong: Some(jong),
..Default::default()
};
}
}
CharacterResult::NewCharacter(new)
}

이 부분에서 문제가 발생하는 것 같은데, 자판 배열과 상관없이 종성에 대해서 동일한 처리를 하는 것 같습니다. 혹 의도하신 동작일까요?

@Riey Riey added bug Something isn't working T-Engine labels Oct 3, 2021
Riey added a commit that referenced this issue Oct 3, 2021
Riey added a commit that referenced this issue Oct 3, 2021
Choseong converted into jongseong even `TreatJongseongAsChoseong` is off
@Riey Riey added the D-Easy EASY label Oct 3, 2021
@Riey Riey closed this as completed in #530 Oct 3, 2021
Riey added a commit that referenced this issue Oct 3, 2021
… is off (#530)

* Add failed test for #529

* Fix #529

Choseong converted into jongseong even `TreatJongseongAsChoseong` is off

* Update CHANGELOG
@Riey Riey mentioned this issue Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working D-Easy EASY T-Engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants