Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated commit strings in some firefox sites #562

Closed
Riey opened this issue Apr 17, 2022 · 0 comments · Fixed by #563
Closed

Duplicated commit strings in some firefox sites #562

Riey opened this issue Apr 17, 2022 · 0 comments · Fixed by #563
Labels
bug Something isn't working D-Normal Normal T-GTK

Comments

@Riey
Copy link
Owner

Riey commented Apr 17, 2022

Example

https://discord.com/app

Summary

오[랜] + = 오랜ㅁ랜ㅁ| not 오랜[ㅁ]

Detail

Due to #535, gtk frontend call update_preedit(FALSE) to end preedit state before commit

It's because chromium doesn't update preedit string when preedit string is same as before, but this can't handle [ㅋ] + = ㅋ[ㅋ] case

So kime now always end preedit state before commit but this produced another bug.

In above site, it commits reset when preedit was ended (it's not always occurred but I'm not sure exact condition).
When this occurred in middle of commit process, it'll double commit string. Furthermore, preedit state also be terminated.

Note that this only affects develop branch, since #536 has not been released.

@Riey Riey added bug Something isn't working T-GTK D-Normal Normal labels Apr 17, 2022
Riey added a commit that referenced this issue Apr 17, 2022
@Riey Riey mentioned this issue Apr 17, 2022
2 tasks
@Riey Riey changed the title Some firefox sties duplicate commit strings. Duplicated commit strings in some firefox sites Apr 17, 2022
Riey added a commit that referenced this issue Apr 17, 2022
Riey added a commit that referenced this issue Apr 17, 2022
@Riey Riey closed this as completed in #563 Apr 17, 2022
Riey added a commit that referenced this issue Apr 17, 2022
@Riey Riey mentioned this issue Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working D-Normal Normal T-GTK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant