add translation layer #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riey
reviewed
Nov 20, 2022
|
Yes, I have tested a non-QWERTY keyboard. In fact I'm using it right now. It works as expected |
|
Does this fix #586? |
|
Yes. It fixes my issue(#586) |
|
Would it be helpful to make it so that users can define translation layer directly on their config file? |
No it should be separated just like hangul layout file. |
|
Okay, so all issues are addressed now. G2G |
SeungheonOh
force-pushed
the
develop
branch
2 times, most recently
from
4656164
to
5034dae
Compare
Riey
requested changes
Nov 20, 2022
Riey
approved these changes
Nov 20, 2022
|
감사합니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added translation layer that allows using keyboards with non-QWERTY layoutse
close #586
Note
Checklist