Adjust search limits #154
Merged
Adjust search limits #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigellute
reviewed
Nov 18, 2019
src/main.rs
Outdated
| @@ -173,8 +173,10 @@ fn main() -> Result<(), failure::Error> { | |||
| app.size = size; | |||
|
|
|||
| // Based on the size of the terminal, adjust the search limit. | |||
| let max_limit = 50; | |||
| app.large_search_limit = min((f32::from(size.height) / 1.5) as u32, max_limit); | |||
| let max_limit = (app.size.height as u32) - 13; | |||
There was a problem hiding this comment.
The max limit of 50 is imposed on us by Spotify, sending more than this will give as a bad response from the API.
There was a problem hiding this comment.
So you could do
max(app.size.height as u32 - 13, 50);
Rigellute
approved these changes
Nov 18, 2019
ghost
mentioned this pull request
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When terminal size is changed, some contents are not showed in the table. Additionally, regardless terminal size, search returns only 4 contents.
Here, I tried to fix these problem, i adjust search limits depending on the terminal size. However, parameters I used here are not led deductively but empirically.
If you know the way to get height of each block, preferable implementation can be available. For me, my implementation is not smart and if you have any idea, please tell me it.