Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow/unfollow artists #155

Merged
merged 6 commits into from Nov 22, 2019
Merged

Follow/unfollow artists #155

merged 6 commits into from Nov 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2019

Add support for following/unfollowing artists.

Considering #152, it seems that adding/following and deleting/unfollowing have common components and there may be more good abstraction. I will try this after adding and deleting were implemented in other type contents.

Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

Could you add these new bindings to the help.rs menu?

@ghost
Copy link
Author

ghost commented Nov 20, 2019

Added new bindings but some features are not implemented yet. I will soon implement them.

Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I caused you a merge conflict.

If you could rebase and slightly modify the help instruction?

Sorry for the bother!

src/ui/help.rs Outdated
@@ -75,5 +75,15 @@ pub fn get_help_docs() -> Vec<Vec<&'static str>> {
"<Ctrl+u>",
"Pagination",
],
vec![
"Add selected artist, album, or track to the library",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's say only "Follow an artist"

@Rigellute
Copy link
Owner

Great work @echoSayonara!

@Rigellute Rigellute merged commit 5771447 into Rigellute:master Nov 22, 2019
@ghost ghost deleted the follow-artists branch November 22, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant