Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playlist index after search #177

Merged
merged 1 commit into from Dec 2, 2019
Merged

Fix playlist index after search #177

merged 1 commit into from Dec 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2019

After searching, playlist index is changed to None and it makes playlist selection odd.
I deleted a line that binds None to selected_playlist_index and it worked well.

Rigellute
Rigellute reviewed Dec 2, 2019
View reviewed changes
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be Some(0)?

@ghost
Copy link
Author

ghost commented Dec 2, 2019

You are right. Fixed it.

Rigellute
Rigellute approved these changes Dec 2, 2019
View reviewed changes
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @echoSayonara 👍

@Rigellute Rigellute merged commit 50b7638 into Rigellute:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Rigellute