Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle playlist unfollowing #399

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Correctly handle playlist unfollowing #399

merged 1 commit into from
Apr 16, 2020

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Apr 13, 2020

How to reproduce the problem:

  1. Follow any playlist, it will appear in the left frame "Playlists"
  2. Search for any other playlist and select it in the corresponding frame
  3. Press 'D'
    The one that you were following will disappear.

A simpler case - have no playlists followed and press 'D' - the application will panic with an out of bounds.

Unfollowing playlists from search results should be handled separately.

Rigellute
Rigellute approved these changes Apr 16, 2020
View reviewed changes
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch.

Looks good, thank you

@Rigellute Rigellute merged commit c4a46c7 into Rigellute:master Apr 16, 2020
@slumber slumber mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigellute Rigellute Rigellute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slumber @Rigellute