Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next/prev page, jump to start/end to user config #566

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

Toaster192
Copy link
Contributor

resolves #482
@AndydeCleyre, @vidurb might want to know

This allows the 4 keybinds to be bound to something else (something that doesn't colide with people's tmux keybinds and such)

@sputnick1124 sputnick1124 mentioned this pull request Sep 19, 2020
6 tasks
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a great addition. Thank you for your work on this.

Looks like we'd want to also update the handlers in these files, to use the new next/prev page config

src/handlers/home.rs
src/handlers/album_list.rs

src/handlers/track_table.rs Outdated Show resolved Hide resolved
src/handlers/track_table.rs Outdated Show resolved Hide resolved
@vidurb
Copy link

vidurb commented Sep 23, 2020

Thanks very much, @Toaster192

Your efforts are much appreciated.

@Toaster192
Copy link
Contributor Author

@Rigellute Good catch, thanks!
@vidurb Thanks for the kind words!
I've literally never before worked with Rust so please excuse me if there are any stupid mistakes (tho it's just a few lines of code)

Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👏

@Rigellute Rigellute merged commit 0620803 into Rigellute:master Sep 30, 2020
@Rigellute
Copy link
Owner

@all-contributors please add @Toaster192 for code

@allcontributors
Copy link
Contributor

@Rigellute

I've put up a pull request to add @Toaster192! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Custom keybinding for pagination (scroll up, down, start, end)
3 participants