Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renovate): overridepostUpdateOptions in renovate configuration #8

Closed
wants to merge 1 commit into from

Conversation

liby
Copy link
Contributor

@liby liby commented Sep 15, 2023

Motivation

This PR addresses an issue we've been encountering with our Renovate configuration, where the pnpm dedupe command inadvertently triggers the postinstall script, leading to a composer: not found error in our PRs initiated by Renovate.

Upon investigation, we found that the pnpm install command, which should theoretically not trigger postinstall due to the --ignore-scripts flag, was not the source of the issue. Instead, the postinstall script was being executed during the pnpm dedupe command.

Further investigation revealed that the pnpm dedupe command was being run due to the postUpdateOptions setting in the https://github.com/RightCapitalHQ/renovate-config that we're extending from. This setting includes pnpmDedupe, which is why pnpm dedupe is being executed.

In the context of Renovate's dependency updates, we do not need to run postinstall, and the execution of composer install within postinstall is causing issues due to the absence of Composer in the Renovate environment.

To temporarily resolve the composer: not found issue and prevent the unwanted execution of postinstall, this PR overrides the postUpdateOptions in our repository's Renovate configuration, removing pnpmDedupe

@liby
Copy link
Contributor Author

liby commented Sep 19, 2023

This will be automatically fixed when renovatebot/renovate#24505 is merged.

@liby liby closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant