add special character - horizontal ellipsis #88
Conversation
| 0x2012, | ||
| 0x2013, | ||
| 0x2014, | ||
| 0x2026, // HORIZONTAL ELLIPSIS |
There was a problem hiding this comment.
#req No need to comment, unless you want to go through and comment all of them. I prefer to just look up the appropriate code in the .m file if you need it. (Commenting each one could be nice, though - what do you think?)
There was a problem hiding this comment.
Commenting helps a little here, but as you say, one could just look in .m file. I have no strong feelings either way.
If I were to put on my "let's over-engineer-this" hat, I could suggest that the comment could be some form that would allow the script to sanity-check the name it derives against the name that the author intended. But it's not a hat day.
There was a problem hiding this comment.
That's just one more thing to get out of sync. The .m file is law - if it's right, pretty much nothing else matters. And that array is kept sorted in code just so it's easy to find where to insert new characters later.
| @@ -155,6 +155,7 @@ | |||
| CDFDF5501B51880D00A1AD42 /* NSDictionary+BONEquality.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSDictionary+BONEquality.m"; sourceTree = "<group>"; }; | |||
| CDFDF5531B518F3900A1AD42 /* BONDictionaryEqualityTestCase.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BONDictionaryEqualityTestCase.m; sourceTree = "<group>"; }; | |||
| DC26879CFC50F3E9302E163B /* Pods-Tests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Tests.debug.xcconfig"; path = "Pods/Target Support Files/Pods-Tests/Pods-Tests.debug.xcconfig"; sourceTree = "<group>"; }; | |||
| E19B7EA11BF3C517002CD3D8 /* BONSpecialGenerator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BONSpecialGenerator.swift; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
#req this is still referencing the one from the Example project.
…ipsis add special character - horizontal ellipsis
|
Thanks @mr-fixit! |
add '...'
add generator script to project to ease finding it.