RZFilteredCollectionList - indexPathOfObject: bug #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indexPath if the object is in the source list, but not the newly filtered list
|
@bsmith11 might want to also test that it works when the filtered list contains the desired object, since there is no code currently testing that. |
|
|
||
| return [NSIndexPath indexPathForRow:filteredRow inSection:filteredSection]; | ||
|
|
||
| if ([sectionIndexSet containsIndex:indexPath.row]) { |
There was a problem hiding this comment.
#nth single point of return, per style guide.
|
@bsmith11 Has my blessing. Make Zev's updates if you have time but otherwise good to have this merged. |
bsmith11
added a commit
that referenced
this pull request
Nov 5, 2015
…ion-list-indexpath-of-object RZFilteredCollectionList - indexPathOfObject: bug
bsmith11
deleted the
bugfix/bsmith11/filtered-collection-list-indexpath-of-object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where calling indexPathOfObject: was returning an incorrect indexPath if the object is in the source list, but not the newly filtered list. I added a test as well.