Bugfix: Content Height Adjustment (#31)

* Adjust alignment of top and bottom constraint to line up with safe area
Rightpoint · May 11, 2021 · 5ec0fe5 · 5ec0fe5
1 parent 91289cc
commit 5ec0fe5
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/RPStackable.podspec b/RPStackable.podspec
@@ -9,7 +9,7 @@
 Pod::Spec.new do |s|
   s.name             = 'RPStackable'
   s.module_name      = "Stackable"
-  s.version          = '0.1.4'
+  s.version          = '0.1.5'
   s.summary          = 'Stackable is a delightful and declarative set of utilities for UIStackView.'
 
 # This description is used to generate tags and improve search results.

diff --git a/Stackable/ScrollingStackView.swift b/Stackable/ScrollingStackView.swift
@@ -35,29 +35,44 @@ open class ScrollingStackView: UIScrollView {
         return super.touchesShouldCancel(in: view)
     }
 
+    open override func safeAreaInsetsDidChange() {
+        super.safeAreaInsetsDidChange()
+        topSafeAreaConstraint?.constant = safeAreaInsets.top
+        bottomSafeAreaConstraint?.constant = safeAreaInsets.bottom
+    }
+
+    var topSafeAreaConstraint: NSLayoutConstraint?
+    var bottomSafeAreaConstraint: NSLayoutConstraint?
+
     /// A container used to enforce that the stack content stays at least the height of the frame.
     private let contentView = UIView()
 
     public init() {
         super.init(frame: .zero)
 
+        contentInsetAdjustmentBehavior = .never
+
         addSubview(contentView)
         contentView.translatesAutoresizingMaskIntoConstraints = false
         contentView.clipsToBounds = false
-
+
+        topSafeAreaConstraint = contentView.topAnchor.constraint(equalTo: topAnchor, constant: safeAreaInsets.top)
+        topSafeAreaConstraint?.isActive = true
+
+        bottomSafeAreaConstraint = contentView.bottomAnchor.constraint(equalTo: bottomAnchor, constant: safeAreaInsets.bottom)
+        bottomSafeAreaConstraint?.isActive = true
+
         NSLayoutConstraint.activate([
-            contentView.topAnchor.constraint(equalTo: topAnchor),
             contentView.leadingAnchor.constraint(equalTo: leadingAnchor),
             contentView.trailingAnchor.constraint(equalTo: trailingAnchor),
-            contentView.bottomAnchor.constraint(equalTo: bottomAnchor),
-
-            contentView.heightAnchor.constraint(greaterThanOrEqualTo: layoutMarginsGuide.heightAnchor),
-            contentView.widthAnchor.constraint(equalTo: widthAnchor),
+
+            contentView.heightAnchor.constraint(greaterThanOrEqualTo: safeAreaLayoutGuide.heightAnchor),
+            contentView.widthAnchor.constraint(equalTo: frameLayoutGuide.widthAnchor),
         ])
-        
+
         contentView.addSubview(stackView)
         stackView.translatesAutoresizingMaskIntoConstraints = false
-        
+
         NSLayoutConstraint.activate([
             stackView.topAnchor.constraint(equalTo: contentView.layoutMarginsGuide.topAnchor),
             stackView.leadingAnchor.constraint(equalTo: contentView.layoutMarginsGuide.leadingAnchor),