Air_Purge triggered from Shock stability option L or R

[graysonk95]

I've tried using the stability options (l/r) for Shocks in the past and I have always gotten this same issue. If the vehicle has a sound to be played by the air_purge trigger, it plays whenever the vehicle rocks left to right.
I'm not sure if this is a glitch, unfinished feature, or what, but I don't think this is the intended operation of that sound trigger.
Plus stability seems to have no impact on handling.
https://www.youtube.com/watch?v=FWEDlsFNySs&feature=youtu.be

I have thought of putting a creak sound as air_purge to make it sound like the suspension is creaking, but the trigger stutters way too much for that to work.

[ohlidalp]

@graysonk95 I don't know how are the l/r flags supposed to work, but I suppose it's not very widely used and perhaps not configurable enough.

The AIR_PURGE trigger seems a little overused in general.

I'll take care of this later when I introduce Lua scripting.

[graysonk95]

Like I said in the OP, I have never noticed the flags having any noticeable impact on handling.

Speaking of, that brings to mind another depreciated feature involving the air trigger.
I'll create a ticket for it since it involves the wheels2 section, but causes the air sound to play on vehicles regardless of the section used to define the wheels.
Here: #446

[ohlidalp]

There's a bug in spawning code (damn copy-pasting!) 😊
The left stability shock is registered as both right+left shock, while the right one is ignored. 😊

RigSpawner::ProcessShock(RigDef::Shock & def)
https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4158

Left active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4179
Right active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4185