New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air_Purge triggered from Shock stability option L or R #442

Closed
graysonk95 opened this Issue Oct 9, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@graysonk95

graysonk95 commented Oct 9, 2015

I've tried using the stability options (l/r) for Shocks in the past and I have always gotten this same issue. If the vehicle has a sound to be played by the air_purge trigger, it plays whenever the vehicle rocks left to right.
I'm not sure if this is a glitch, unfinished feature, or what, but I don't think this is the intended operation of that sound trigger.
Plus stability seems to have no impact on handling.
https://www.youtube.com/watch?v=FWEDlsFNySs&feature=youtu.be

I have thought of putting a creak sound as air_purge to make it sound like the suspension is creaking, but the trigger stutters way too much for that to work.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 30, 2015

Member

@graysonk95 I don't know how are the l/r flags supposed to work, but I suppose it's not very widely used and perhaps not configurable enough.

The AIR_PURGE trigger seems a little overused in general.

I'll take care of this later when I introduce Lua scripting.

Member

only-a-ptr commented Oct 30, 2015

@graysonk95 I don't know how are the l/r flags supposed to work, but I suppose it's not very widely used and perhaps not configurable enough.

The AIR_PURGE trigger seems a little overused in general.

I'll take care of this later when I introduce Lua scripting.

@only-a-ptr only-a-ptr self-assigned this Oct 30, 2015

@only-a-ptr only-a-ptr added this to the 0.5 "ZeroPoint" milestone Oct 30, 2015

@graysonk95

This comment has been minimized.

Show comment
Hide comment
@graysonk95

graysonk95 Oct 30, 2015

Like I said in the OP, I have never noticed the flags having any noticeable impact on handling.

Speaking of, that brings to mind another depreciated feature involving the air trigger.
I'll create a ticket for it since it involves the wheels2 section, but causes the air sound to play on vehicles regardless of the section used to define the wheels.
Here: #446

graysonk95 commented Oct 30, 2015

Like I said in the OP, I have never noticed the flags having any noticeable impact on handling.

Speaking of, that brings to mind another depreciated feature involving the air trigger.
I'll create a ticket for it since it involves the wheels2 section, but causes the air sound to play on vehicles regardless of the section used to define the wheels.
Here: #446

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 3, 2015

Member

There's a bug in spawning code (damn copy-pasting!) 😊
The left stability shock is registered as both right+left shock, while the right one is ignored. 😊

RigSpawner::ProcessShock(RigDef::Shock & def)
https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4158

Left active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4179
Right active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4185

Member

only-a-ptr commented Nov 3, 2015

There's a bug in spawning code (damn copy-pasting!) 😊
The left stability shock is registered as both right+left shock, while the right one is ignored. 😊

RigSpawner::ProcessShock(RigDef::Shock & def)
https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4158

Left active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4179
Right active shock: https://github.com/only-a-ptr/rigs-of-rods/blob/editor-python-dirty/source/main/physics/input_output/RigSpawner.cpp#L4185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment