Fixes #2607
Merged
Fixes #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine! Although they stop when you get out of the actor, don't know if that's normal. |
tritonas00
approved these changes
Oct 18, 2020
Fixes RigsOfRods#2430 Problem: Beacon props generated by `ActorSpawner::ProcessWings()` weren't passed on to GfxActor. Reason: Props were passed on GfxActor creation which happened before `ActorSpawner::ProcessWings()` Solution: Added `GfxActor::RegisterProps()` which is invoked after `ActorSpawner::ProcessWings()`
ohlidalp
force-pushed
the
fix-aerolights
branch
from
0db209d
to
9432672
Compare
That's actually a fantastic observation which provoked 2 additional fixes 👍 |
|
Works great except one issue, the blinker indicators in the HUD (mygui) are not working now. |
Problem: those dashboard entries were updated from incorrect place - `Actor::UpdateFlareStates()` instead of `Actor::updateDashBoards()`
|
Fixed both the blinker HUD lamps and the logged |
tritonas00
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2430
Problem: Beacon props generated by
ActorSpawner::ProcessWings()weren't passed on to GfxActor.Reason: Props were passed on GfxActor creation which happened before
ActorSpawner::ProcessWings()Solution: Added
GfxActor::RegisterProps()which is invoked afterActorSpawner::ProcessWings()