Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flickering shadows #2884

Closed
wants to merge 1 commit into from

Conversation

tritonas00
Copy link
Collaborator

Example terrain: https://sim-monsters.com/files/file/3734-orlando-2021/

Before: https://streamable.com/jc4591
After: https://streamable.com/nos1a2
(I don't know why it recorded on fast forward 馃槅)

Also fixes sloppy rendered survey map with shadows:
Before:
screenshot_2022-03-28_11-54-25_1
After:
screenshot_2022-03-28_11-54-41_1

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Mar 28, 2022

@paroj i go a bit blind here, is this the right way to handle depth fighting issues?
Why on windows VS 2019 exposes the issue while VS 2017 doesn't?
On linux side, it happens with some gpus (like it happens on my laptop intel 5500 and it doesn't on my desktop intel 4600 gpu)

@paroj
Copy link
Contributor

paroj commented Mar 28, 2022

@tritonas00 tritonas00 marked this pull request as draft March 29, 2022 09:41
@tritonas00
Copy link
Collaborator Author

@paroj
Copy link
Contributor

paroj commented Mar 30, 2022

It creates this issue https://discord.com/channels/136544456244461568/189904947649708032/958169316526796830

this is to be expected when you move geometry forward/ back a little.

To be safe, you should only use depth_bias in shadow caster passes and for decals.

@tritonas00 tritonas00 closed this Mar 30, 2022
@tritonas00 tritonas00 deleted the shadows-flicker branch March 30, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants