Angelscript vehicle engine bindings #3048
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gear-vector prep code was moved from ActorSpawner.cpp to EngineSim.cpp EngineSim.h: - added doxy comments about 'engine' keyword args - added `getDiffRatio()` getter so `m_diff_ratio` is no longer a dead attr - will be bound to AngelScript later
This touches many files but it's just find&replace of the renamed functions in EngineSim.h This is a preparation for AngelScript bindings which must all be `camelCase()`.
Deleted `EngineSim::shiftmodes`, using global `SimGearboxMode` (see Application.h) for everything. The enums are the same except for syntax.
EngineSim class upgraded to RefCountingObject - that means all codebase uses EngineSimPtr now. Ambiguous func `EngineSim::getEngineTorque()` renamed to `getCurEngineTorque()` Func `EngineSim::getShiftingToGear()` renamed to `getShifTargetGear()` EngineSim.h - some more doxygen doc shuffling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing piece of #3030. Will come with a demo script when finished.