'add_animation' - shift stick now moves smoothly #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CODECHANGES: * gfxdata.h - just comments * gfxActor.h - CalcPropAnimation() decluttered - pass PropAnim& instead of aliases. This was technical debt after splitting animators/prop anims. * gfxActor.cpp - mostly find&replace updates of CalcPropAnimation()
Applies to sources: shifterman1, shifterman2, shifterseq, shifterlin. Tested on Ford Mustang https://forum.rigsofrods.org/resources/ford-mustang-1979-1982.712/ - I'm sure PoLi would approve :)
CuriousMike56
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only visual improvement - the engine shift time is not affected.
Applies to sources: shifterman1, shifterman2, shifterseq, shifterlin.
The transition speed is hardcoded at the moment - I'll try to use the 'shift time' parameter from 'engoption'. UPDATE: I'll leave it as-is for now.
Tested on Ford Mustang https://forum.rigsofrods.org/resources/ford-mustang-1979-1982.712/ - I'm sure PoLi would approve :)
