Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rot_yxz for SR road rotations Y then X, Z #3131

Merged
merged 2 commits into from Mar 11, 2024

Conversation

cryham
Copy link
Contributor

@cryham cryham commented Feb 22, 2024

This fixes for me road roll angles.
Like you said, they were bad. Yaw was only working ok.
Before:
0237``
After:
22_18-08-09
Track has this road TestC1-Circle-road.tobj, it has a circle with all points: -16, yaw, 0
TestC1-Circle-road.txt
This would be important for SR tracks roads, mainly for better bridge entries.

@CuriousMike56
Copy link
Collaborator

Please check other maps with default roads (North St Helens, Small Island, etc)

@cryham
Copy link
Contributor Author

cryham commented Feb 26, 2024

Agh. Okay so this isn't so simple.
Since this is for all .tobj, and there were x and z rotations != 0 there, it goes somewhat bad there.
So the solution would be to leave it as it was and add this as a different option for SR roads only.

Ok I think easiest will be a new command line that will switch to this way only in SR files.
in bool TObjParser::ProcessCurrentLine()

@cryham
Copy link
Contributor Author

cryham commented Feb 26, 2024

Okay possibly like this. I'll check it tomorrow.

@cryham
Copy link
Contributor Author

cryham commented Feb 26, 2024

Right. It works as before now.
And with rot_yxz put in .tobj it works new way for SR.

@cryham cryham changed the title 🐛Fixed road X rotations Add rot_yxz for SR road rotations Y then X, Z Feb 26, 2024
Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach and the minimal code change. I'll merge after Mike confirms everything works OK. Sorry about taking long to respond.

@ohlidalp ohlidalp merged commit 8154504 into RigsOfRods:master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants