Exception hardening #3144
Merged
Exception hardening #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohlidalp
force-pushed
the
exception_hardening
branch
2 times, most recently
from
ef0e375
to
35f93cb
Compare
Removed helper `HandleException()` - all handling is now done via `forwardExceptionAsScriptEvent()`.
Codechanges:
* Application: added `HandleGenericException()` helper + convenience wrapper for msg queue.
* main: wrapped all message processing cases in `try{}catch()` - a lot of boilerplate, but likely worth it.
* Cache system: removed custom exception handling - just propagate exceptions up and handle in bulk.
If flexbody cannot be loaded for any reason, always create a placeholder - this was previously done only if removed via Tuning system.
/*NEW*/enum class PlaceholderType
{
NOT_A_PLACEHOLDER,
TUNING_REMOVED_PLACEHOLDER,
FAULTY_FORSET_PLACEHOLDER,
FAULTY_MESH_PLACEHOLDER,
};
The FlexbodyDebug UI was extended to recognize placeholders and not crash but display the placeholder type instead.
ohlidalp
force-pushed
the
exception_hardening
branch
from
35f93cb
to
3302121
Compare
This crash happened to me repeatedly when I removed an actor which was constantly exploding and resetting - apparently the MODIFY_ACTOR was queued when DELETE_ACTOR was already in queue.
|
Merging in good faith without peer approval - I've been developing other branches on top of this for about a week, and didn't observe any issues, in fact I added a few more error tolerance commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should put a stop to the game panicking on any unhandled exceptions, which are usually trivially recoverable, like this dialog which was caused by a .mesh file missing from a terrain:
All exceptions which happen during processing message queue are now automatically logged to RoR.log and also forwarded to AngelScript as game event - a trick already widely used in OGRE bindings, see
SE_GENERIC_EXCEPTION_CAUGHT.