Tuning: fixed managedmats for meshes in addonpart bundles. #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we do material setup _after_ we load meshes via OGRE, we need a placeholder for every managedmat - if not found, OGRE substitutes them with 'BaseWhite' which breaks subsequent processing. Problem: placeholders were only created in the vehicle bundle's resource group, not in addonpart's bundle resource group.
(request may come from 'Browse all' button or script).
|
Additionally, I added an addonpart conflict check which always runs upon equipping an addonpart (because request may come from 'Browse all' button or script). Screenshot shows the dialog that appears if conflict is found - it's a bit crude but thorough.
|
Also moved the code from CacheSystem.cpp to AddonPartFileFormat.cpp, into a new func `DoubleCheckForAddonpartConflict()` Also extended the GUI_MessageBox.cpp to always reprint the dialog to RoR.log
ohlidalp
force-pushed
the
Mike_managed-mat-tweaks
branch
from
0d89042
to
0282e92
Compare
|
Added 'OK' button to the conflicts doublecheck dialog.
Also extended the GUI_MessageBox.cpp to always reprint the dialog to RoR.log |
CuriousMike56
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we do material setup after we load meshes via OGRE, we need a placeholder for every managedmat - if not found, OGRE substitutes them with 'BaseWhite' which breaks subsequent processing.
Problem: placeholders were only created in the vehicle bundle's resource group, not in addonpart's bundle resource group.
Fix: create placeholders also for all addonpart bundles.