Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Replaced jsoncpp with Poco::JSON #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔧 Replaced jsoncpp with Poco::JSON #141

wants to merge 1 commit into from

Conversation

AnotherFoxGuy
Copy link
Member

Part of #139

@AnotherFoxGuy AnotherFoxGuy mentioned this pull request Apr 14, 2022
Open
6 tasks
ohlidalp
ohlidalp requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Undo the SendMessage() -> SWSendMessage() find&replace please. I see no reason for that.
  • Make the JsonToString() macro a function - I see no reason to make it a macro.

@AnotherFoxGuy
Copy link
Member Author

Undo the SendMessage() -> SWSendMessage() find&replace please. I see no reason for that.

The issue with that is that the SendMessage() function conflicts with the SendMessage() from Microsoft
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-sendmessage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohlidalp ohlidalp ohlidalp requested changes

@tritonas00 tritonas00 Awaiting requested review from tritonas00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnotherFoxGuy @ohlidalp