Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/classes #2

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Feature/classes #2

merged 6 commits into from
Sep 4, 2023

Conversation

RileyManda
Copy link
Owner

@RileyManda RileyManda commented Sep 4, 2023

I have completed the required implementation of the School Library Application according to the stipulated requirements:

The following features have been implemented:

Classes

  • Created person, student and teacher classes
  • Created person class with getters and setters
  • Implemented person,teacher and student class
  • Followed gitflow rules

In addition, I have fulfilled the following project requirements:

General requirements

Please kindly review my implementation and suggest any changes and improvements.

I look forward to your feedback.

Thank you 🙏🏻

Best regards,

Copy link

@prolajumokeoni prolajumokeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RileyManda

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • The classes to represent students, person and teachers have been implemented💪🏿

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@RileyManda RileyManda merged commit 4ab47d4 into dev Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants