Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add varaidic logging, Logger class. #48

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add varaidic logging, Logger class. #48

merged 1 commit into from
Aug 11, 2023

Conversation

karnkaul
Copy link
Collaborator

Whoops, deleted the branch by mistake!

As decided, source location info has been replaced with variadic arguments to forward to std::format.

Close #38.

Comment from @Rinzii on original PR:

Could we still keep information for verbose logging with the ability to enable it though the Config but instead use something like __ FILE __ over source location? I know __ FILE __ and such is mega C like, but from my understanding its the best way we can handle this problem without source_location. What are your thoughts @karnkaul ?

@karnkaul karnkaul requested a review from Rinzii August 11, 2023 04:37
@karnkaul
Copy link
Collaborator Author

karnkaul commented Aug 11, 2023

@Rinzii Contributions are welcome for the __FILE__ feature. 😉

@karnkaul karnkaul marked this pull request as ready for review August 11, 2023 04:38
@Rinzii
Copy link
Owner

Rinzii commented Aug 11, 2023

@Rinzii Contributions are welcome for the __FILE__ feature. wink

I'm still working on the vulkan code, but can switch gears if help is needed! Or if @Kouros26 is not working on anything major right now and is down they could also give a go at it. 😄

Copy link
Owner

@Rinzii Rinzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now though I don't see any issues with the current code so I'm going to approve this all and create an issue for bringing back in the verbose logging using __ FILE __ and such. ^^

@karnkaul
Copy link
Collaborator Author

For now though I don't see any issues with the current code so I'm going to approve this all and create an issue for bringing back in the verbose logging using __ FILE __ and such. ^^

Sounds good!

@karnkaul karnkaul merged commit aaa97ac into main Aug 11, 2023
4 checks passed
@karnkaul karnkaul deleted the karnage/format-log branch August 11, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate std::format into the logger
2 participants