Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] VAL dto wrong dto name and/or sudden change of returned dto object name #358

Closed
iann838 opened this issue Sep 1, 2020 · 2 comments
Closed

[BUG] VAL dto wrong dto name and/or sudden change of returned dto object name #358

iann838 opened this issue Sep 1, 2020 · 2 comments
Labels
api: val-match-v1 closed: resolved scope: val topic: documentation type: inconsistency Typos, dead links, out dated information, or weird behavior.

Comments

@iann838
Copy link

iann838 commented Sep 1, 2020

Expected outcome:

KillDto (in dev portal)

gameTime
roundTime

Actual outcome since August 31st:

Returned KillDto

timeSinceGameStartMillis
timeSinceRoundStartMillis

Developer impact

HAHAHAHA
@MingweiSamuel
Copy link

Well at least the names are more descriptive

MingweiSamuel added a commit to MingweiSamuel/riotapi-schema that referenced this issue Sep 1, 2020
@MingweiSamuel
Add undocumented val-match-v1.KillDto.timeSinceXyzStartMillis override
7e21882 
RiotGames/developer-relations#358
@MingweiSamuel MingweiSamuel mentioned this issue Sep 15, 2020
Closed
@RiotTuxedo
Copy link
Contributor

The documentation has been updated to reflect this. Sorry about the unexpected change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: val-match-v1 closed: resolved scope: val topic: documentation type: inconsistency Typos, dead links, out dated information, or weird behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MingweiSamuel @RiotTuxedo @iann838