Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS][BUG] New val-match-v1.getRecent docs have wrong return type #366

Closed
MingweiSamuel opened this issue Sep 15, 2020 · 1 comment
Closed

[DOCS][BUG] New val-match-v1.getRecent docs have wrong return type #366

MingweiSamuel opened this issue Sep 15, 2020 · 1 comment
Labels
api: val-match-v1 closed: resolved scope: val topic: documentation type: inconsistency Typos, dead links, out dated information, or weird behavior.

Comments

@MingweiSamuel
Copy link

MingweiSamuel commented Sep 15, 2020 •
edited

https://developer.riotgames.com/apis#val-match-v1/GET_getRecent

Currently says:

Return value: string

Should be something like (maybe not named RecentMatchesDto):

Return value: RecentMatchesDto

RecentMatchesDto

Name Data Type Description
currentTime long Current time in epoch seconds
matchIds List[string] List of match ID strings
MingweiSamuel added a commit to MingweiSamuel/riotapi-schema that referenced this issue Sep 15, 2020
@MingweiSamuel
Add return type override, use for val-match-v1.getRecent
612f602 
RiotGames/developer-relations#366
@MingweiSamuel MingweiSamuel mentioned this issue Sep 15, 2020
Closed
@RiotTuxedo
Copy link
Contributor

This issue should now be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: val-match-v1 closed: resolved scope: val topic: documentation type: inconsistency Typos, dead links, out dated information, or weird behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MingweiSamuel @RiotTuxedo