[DOCS][BUG] match-v5 MatchDto: match_id is actually matchId & data_version is actually dataVersion

[ciriousjoker]

Bug Description
match_id is actually called matchId on MatchDto (match-v5)

Problem Description
DTO is incorrect.

Expected Result

{
  "metadata": {
    "data_version": "2",
    "match_id": "...",

Actual Result

{
  "metadata": {
    "dataVersion": "2",
    "matchId": "...",

Developer Impact
Low, you can rename the field in your interface once you realize that things don't work.

Player Impact
None.

Preconditions
User has to read the documentation in the first place instead of generating the interfaces from the json response.

Repro Steps
Make a sample response on the new match-v5 endpoint here:
https://developer.riotgames.com/apis#match-v5/GET_getMatch

Issue Comments
I'm writing this in Javascript, perhaps there's some behind the scenes magic that javascriptifies the field names? I doubt it though since it's also reproducible in the official test environment.

[ciriousjoker]

Same exact thing with the data_version field.

Documentation says data_version, reality says dataVersion.

[MingweiSamuel]

@ciriousjoker Can you please update the issue title to include both match_id and data_version, and prefix with [DOCS][BUG] as well, for clarity? Thanks

[ciriousjoker]

This has been fixed in the docs.