Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuvutu ripper #387

Merged
merged 4 commits into from
Jan 16, 2018
Merged

Yuvutu ripper #387

merged 4 commits into from
Jan 16, 2018

Conversation

rephormat
Copy link
Contributor

@rephormat rephormat commented Jan 13, 2018

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix

Description

Added yuvutu.com ripper #38

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 32.349% when pulling 4464fa8 on rephormat:yuvutu-ripper into f1e6d33 on RipMeApp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 32.349% when pulling 4464fa8 on rephormat:yuvutu-ripper into f1e6d33 on RipMeApp:master.

@cyian-1756
Copy link
Collaborator

Everything looks good expect the unit test, could you add a test for the video ripper as well?

@rephormat
Copy link
Contributor Author

@cyian-1756 video ripper test added.

@coveralls
Copy link

coveralls commented Jan 14, 2018

Coverage Status

Coverage increased (+0.4%) to 32.677% when pulling 38231c8 on rephormat:yuvutu-ripper into f1e6d33 on RipMeApp:master.

@cyian-1756
Copy link
Collaborator

@rephormat Looks good to me, I'll merge it in for 1.7.13

@cyian-1756 cyian-1756 merged commit 654f6e3 into RipMeApp:master Jan 16, 2018
@rephormat rephormat deleted the yuvutu-ripper branch January 16, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants