Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtStationRipper: fix ripping from user profiles which many projects #816

Merged
merged 2 commits into from Jul 21, 2018
Merged

ArtStationRipper: fix ripping from user profiles which many projects #816

merged 2 commits into from Jul 21, 2018

Conversation

mbc07
Copy link
Contributor

@mbc07 mbc07 commented Jul 16, 2018

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

This PR fixes issue #776 by properly handling user profiles with more than 50 published projects. It also fixes an off-by-one bug which I still not sure how I didn't catch in the initial implementation (basically it would skip the first project of every user profile)

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@coveralls
Copy link

coveralls commented Jul 16, 2018

Coverage Status

Coverage decreased (-0.03%) to 38.552% when pulling 9bb28cf on mbc07:ArtStation_multi_page_fix into cbfd363 on RipMeApp:master.

@cyian-1756 cyian-1756 merged commit f3fe3eb into RipMeApp:master Jul 21, 2018
@mbc07 mbc07 deleted the ArtStation_multi_page_fix branch July 24, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArtStation- JSONArray[50] not found error
3 participants