Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Update version to 1.8.0 #122

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Update version to 1.8.0 #122

merged 1 commit into from
Nov 22, 2019

Conversation

andrecardoso
Copy link
Contributor

Description

Update Rise Cache version to not use double digits in the last part.

Motivation and Context

Why is this change required? What problem does it solve?
This change fixes https://github.com/Rise-Vision/rise-launcher-electron/issues/831 that is caused because the _compareVersionNumbers in widget-common doesn't work well when there's more than one digit in the version parts.

How Has This Been Tested?

Tested manually by updating player on stage and having a presentation set up with Image Widgets pointing to external URLs.

Release Plan:

  • As the Submitter, upon requesting review of this pull request, I confirm that the Release Checklist has been completed.
  • As the Reviewer, upon approving the changes in this PR, I confirm I have reviewed and I agree that the Release Checklist has been completed

Release Checklist Items Skipped?

If any Release Checklist items were intentionally skipped, please provide which ones and the reasons why

Copy link

@olegrise olegrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrecardoso excellent work !!! :)

@andrecardoso andrecardoso merged commit 756c6c3 into master Nov 22, 2019
@andrecardoso andrecardoso deleted the staging/change-version branch November 22, 2019 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants