Add typescript example #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteyycz
force-pushed
the
typescript-example
branch
from
cd907a7
to
e9f47e9
Compare
solkimicreb
requested changes
Mar 13, 2020
There was a problem hiding this comment.
Please add the example to the relevant readme section: https://github.com/RisingStack/react-easy-state#beginner (like the other ones).
I also left a few comments. Looks nice otherwise, I look forward to merging this (:
peteyycz
force-pushed
the
typescript-example
branch
4 times, most recently
from
3fdda90
to
5014b93
Compare
solkimicreb
requested changes
Mar 17, 2020
peteyycz
force-pushed
the
typescript-example
branch
3 times, most recently
from
9eaafc0
to
aa5112c
Compare
rolandszoke
requested changes
Mar 17, 2020
peteyycz
force-pushed
the
typescript-example
branch
from
aa5112c
to
cb91fc0
Compare
solkimicreb
requested changes
Mar 17, 2020
peteyycz
force-pushed
the
typescript-example
branch
2 times, most recently
from
2416bd4
to
e18b8c9
Compare
solkimicreb
requested changes
Mar 18, 2020
examples/using-typescript/.gitignore
Outdated
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local |
There was a problem hiding this comment.
I missed this, please remove .env.development.local from gitignore.
peteyycz
force-pushed
the
typescript-example
branch
from
e18b8c9
to
ad4511f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.