Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images from 'dotnetack.md' not displaying images and hyperlinks go to nowhere #34

Open
joewheaton opened this issue Aug 16, 2021 · 7 comments
Labels
🐛 bug Something isn't working 🌐 Viewer QGIS

Comments

@joewheaton
Copy link

The Problem

The update of Acknowledgements associated with completing Riverscapes/RaveAddIn#3 , revealed that any hyperlinks within the acknowledgements do not open in an external browser (what we want) and instead just open within the frame.

image

This is related to Riverscapes/RaveAddIn#155 but different behavior here in the QPlugin.

Reproduction steps

Watch second part of video for behavior:
![Not loading https://youtu.be/Z_gW8c-Nk3U](http://img.youtube.com/vi/Z_gW8c-Nk3U
/0.jpg)

What we'd like

Is it possible to get the images to show up and the hyperlinks to open the user's default browser?

@joewheaton joewheaton added the 🐛 bug Something isn't working label Aug 16, 2021
@joewheaton joewheaton added this to the QRAVE 0.6 milestone Aug 16, 2021
@philipbaileynar
Copy link
Contributor

I just tested two possible solutions. Neither worked.

Anchor target attribute

I tried putting in a HTML link with a target attributeusing the following. Weirdly, this didn't render at all and Jekyll just spat out the raw HTML in the final document. I thought straight HTML got interpreted?

<a href="https://northarrowresearch.com" target=”_blank”>NAR</a>

Markdown Attributes

I tried an approach that I found here. In ArcRAVE this did nothing. The link just opened in the About form web control. In QRAVE it just caused a blank page in the form's web control.

RAVE is brought to you for free by the [Riverscapes Consortium](http://riverscapes.xyz){:target="_blank"}

@MattReimer
Copy link
Member

I suspect this could be more about configuring the control itself than anything to do with the markdown. There might be a "render images" checkbox or a "open links in browser" checkbox. I'll take a look when I'm back

@MattReimer
Copy link
Member

Ok, so external links were easy but apparently the control I'm using won't do image downloads and trying to use the QWebEngineView crashes the designer immediately

I'm not alone in my frustration here:
qgis/QGIS#41381

No solution yet. We might need a workaround.

MattReimer added a commit that referenced this issue Aug 31, 2021
@MattReimer MattReimer modified the milestones: QRAVE 0.6, QRAVE 0.7 Aug 31, 2021
@MattReimer MattReimer removed their assignment Aug 31, 2021
@joewheaton
Copy link
Author

One work around for now is we remove images from the markdown.

So am I to understand correctly that getting the links to open in browser was okay?

@MattReimer
Copy link
Member

Yeah. The browser pops open just fine.

I think the no images thing is probably the short term fix. I would like them to load (and there's no reason we shouldn't be able to do that) but the obvious fix didn't work.

I'll leave this open and we'll circle back in the next milestone.

MattReimer added a commit that referenced this issue Sep 3, 2021
@philipbaileynar philipbaileynar self-assigned this Oct 25, 2021
@philipbaileynar
Copy link
Contributor

Action required: Remove images from markdown file.

@MattReimer
Copy link
Member

The short term fix is done for now. I'm pushing this issue forward so we eventually get a proper fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌐 Viewer QGIS
Projects
None yet
Development

No branches or pull requests

3 participants