Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding XSD to basemaps and tile types #85

Merged
merged 4 commits into from
May 25, 2021
Merged

Adding XSD to basemaps and tile types #85

merged 4 commits into from
May 25, 2021

Conversation

MattReimer
Copy link
Member

@MattReimer MattReimer commented May 22, 2021

This change adds support for the following layer types in the XML. It relates to #74

After this change you'll need to add type="wms|tms|xyz" tag to the layers. For now wms, tms, xyz are the choices. I'm open to extending this list.

Also the Basemaps.xml file is hooked into an XSD so watch it for red carefully when you're editing it.

<Layer name="Watershed Boundary Dataset" type="wms" url="https://hydro.nationalmap.gov:443/arcgis/services/wbd/MapServer/WmsServer?">

NOTES:

  • This change allows you to specify new baselayers. it does NOT implement that functionality in ArcRave or QRave.
  • Test this against QRave before merging. It's a pretty safe fix and it shouldn't break anything but I've definitely said that before. UPDATE: Quick test seems to be backward-compatible with QRAVE 0.4.0
  • I'll need validators for this but I've got it covered here Create a webrave symbology validator #77

@MattReimer MattReimer removed the request for review from philipbaileynar May 25, 2021 20:02
@MattReimer MattReimer merged commit fb055fc into master May 25, 2021
MattReimer added a commit that referenced this pull request May 25, 2021
MattReimer added a commit that referenced this pull request May 25, 2021
@MattReimer MattReimer deleted the basemapxsd branch May 25, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌐 Viewer QGIS Our map viewer plugin for QGIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant