fix(linter): fixed false postive in alpinejs tags for H037

thanks @danjac, @khink closes #639
djlint · May 11, 2023 · 6520f63 · 6520f63
1 parent cbf5796
commit 6520f63
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 1 deletion.
diff --git a/src/djlint/rules.yaml b/src/djlint/rules.yaml
@@ -276,4 +276,4 @@
     message: Duplicate attribute found.
     flags: re.I
     patterns:
-    - <\w[^>]*?\s\K([a-z-][a-z-]*?)(?==[^>]+?[^-]\1=[^>]*?>)
+    - <\w[^>]*?\s\K([a-z-:][a-z-]*?)(?==[^>]+?[^-:]\1=[^>]*?>)
diff --git a/tests/test_linter/test_h037.py b/tests/test_linter/test_h037.py
@@ -67,6 +67,72 @@
         ([]),
         id="repeating tags",
     ),
+    pytest.param(
+        (
+            '<img src="img.jpg" :src="isLoaded ? url : defaultValue" />\n'
+            '<tbody class="bg-white" x-data="{ open{{ item.history_id }}: false }" x-bind:class="open{{ item.history_id }} ? \'bg-gray-50\' : '
+            '">'
+        ),
+        (
+            [
+                {
+                    "code": "H006",
+                    "line": "1:0",
+                    "match": '<img src="img.jpg" :',
+                    "message": "Img tag should have height and width attributes.",
+                },
+                {
+                    "code": "H013",
+                    "line": "1:0",
+                    "match": '<img src="img.jpg" :',
+                    "message": "Img tag should have an alt attribute.",
+                },
+                {
+                    "code": "H025",
+                    "line": "2:0",
+                    "match": '<tbody class="bg-whi',
+                    "message": "Tag seems to be an orphan.",
+                },
+            ]
+        ),
+        id="apline tags no match",
+    ),
+    pytest.param(
+        (
+            '<img :src="img.jpg" :src="isLoaded ? url : defaultValue" />\n'
+            '<tbody x-bind:class="bg-white" x-data="{ open{{ item.history_id }}: false }" x-bind:class="open{{ item.history_id }} ? \'bg-gray-50\' : '
+            '">'
+        ),
+        (
+            [
+                {
+                    "code": "H006",
+                    "line": "1:0",
+                    "match": '<img :src="img.jpg" ',
+                    "message": "Img tag should have height and width attributes.",
+                },
+                {
+                    "code": "H013",
+                    "line": "1:0",
+                    "match": '<img :src="img.jpg" ',
+                    "message": "Img tag should have an alt attribute.",
+                },
+                {
+                    "code": "H025",
+                    "line": "2:0",
+                    "match": "<tbody x-bind:class=",
+                    "message": "Tag seems to be an orphan.",
+                },
+                {
+                    "code": "H037",
+                    "line": "1:5",
+                    "match": ":src",
+                    "message": "Duplicate attribute found.",
+                },
+            ]
+        ),
+        id="apline tags match",
+    ),
 ]