fix(linter): fixed false positive on H037

thanks @kai687 closes #633
djlint · May 10, 2023 · e65558c · e65558c
1 parent 5cf1e1c
commit e65558c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 11 deletions.
diff --git a/src/djlint/rules.yaml b/src/djlint/rules.yaml
@@ -276,4 +276,4 @@
     message: Duplicate attribute found.
     flags: re.I
     patterns:
-    - <\w[^>]*?\s\K([a-z][a-z-]*?)(?==[^>]+?\1=[^>]*?>)
+    - <\w[^>]*?\s\K([a-z-][a-z-]*?)(?==[^>]+?[^-]\1=[^>]*?>)
diff --git a/tests/test_linter/test_django_linter.py b/tests/test_linter/test_django_linter.py
@@ -276,16 +276,7 @@
     ),
     pytest.param(
         ('<form action="{% url \'something\' %}" data-action="xxx"></form>'),
-        (
-            [
-                {
-                    "code": "H037",
-                    "line": "1:6",
-                    "match": "action",
-                    "message": "Duplicate attribute found.",
-                }
-            ]
-        ),
+        ([]),
         id="DJ018_data_action",
     ),
     pytest.param(

diff --git a/tests/test_linter/test_h037.py b/tests/test_linter/test_h037.py
@@ -41,6 +41,25 @@
         ([]),
         id="mismatch names",
     ),
+    pytest.param(
+        ('<svg -width="16" -width="2"></svg>'),
+        (
+            [
+                {
+                    "code": "H037",
+                    "line": "1:5",
+                    "match": "-width",
+                    "message": "Duplicate attribute found.",
+                }
+            ]
+        ),
+        id="leading hyphen names",
+    ),
+    pytest.param(
+        ('<svg width="16" stroke-width="2"></svg>'),
+        ([]),
+        id="mismatch hyphen names",
+    ),
     pytest.param(
         (
             '<a href="" ></a><a href=""></a><a href=""></a><a href=""></a><a href=""></a><a href=""></a>'