[BUG] [Linter] H025 False positive when trans tag contains one single quote

[a-edakin]

• I'm on the latest version of djLint
• I've searched the issues I hope I checked all issues related to H025 if it's duplicate sorry:(
• I've read the docs

System Info

• OS: I don't think it's relevent because I could reproduce it on any OS
• Python Version: 3.10.2
• djLint Version: 1.19.4
• template language: django

Issue

False positive H025 issue if HTML's tag attribute contains {% trans "some text with ONE single ' quote" %}.

But if I would use second quote then everything would be fine {% trans "some text with TWO single '' quote" %}.

How To Reproduce

HTML file to reproduce:

<button title="{% trans "text with ONE single ' quote" %}">
</button>

<a title="{% trans "text with ONE single ' quote" %}">
</a>

Command: djlint -

Console output:

templates/test_tag_trans.html
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
H025 1:0 Tag seems to be an orphan. <button title="{% tr
H025 5:0 Tag seems to be an orphan. </a>

Linted 34 files, found 2 errors.

Contents of .djlintrc/pyproject.toml [tool.djlint]

[tool.djlint]
profile="django"
indent = 4
max_line_length=120
blank_line_before_tag="include,for,block"
blank_line_after_tag="load,include,endfor,endblock"
ignore="H021,H022,H006"
files = ["templates"]

[christopherpickering]

Attribute parsing is gonna kill me lol. I'll put out a fix shortly. I'm working hard on an update that will get rid of most regex 😅

[a-edakin]

To fix this issue I just moved trans tag out of attributes

{% trans "text with ONE single ' quote" as tanslated_text %}
<button title="{{ tanslated_text }}">
</button>

[SebastiaanZ]

You've probably already know this, but it's not limited to the trans tag:

     <p>
         <some-tag
-                    onclick="window.location.href = '{% url 'app:view' %}'">
+                    onclick="window.location.href = '{% url 'app:view' %}">
         </some-tag>
     </p>

Although my guess is that you use a generic, not tag/filter specific, method of counting nested quotation marks.

[christopherpickering]

@SebastiaanZ @a-edakin thanks! I should have a release out shortly that covers both cases.

[christopherpickering]

🎉 This issue has been resolved in version 1.19.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀