Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Linter] False positives for duplicate attributes H037 #633

Closed
3 tasks done
kai687 opened this issue May 10, 2023 · 2 comments
Closed
3 tasks done

[BUG] [Linter] False positives for duplicate attributes H037 #633

kai687 opened this issue May 10, 2023 · 2 comments
Labels
🔍 linter 🦠 bug Something isn't working released

Comments

@kai687
Copy link

kai687 commented May 10, 2023

System Info

  • OS: macOS (whatever the latest is)
  • Python Version 3.11.3
  • djLint Version 1.27.0
  • template language: HTML

Issue

The rule H037 "Duplicate attribute found" flags attributes as duplicate even if they only partially match, so SVG attributes "width" and "stroke-width" are flagged.

How To Reproduce

  1. Create a file test.html with the content:

    <svg width="16" stroke-width="2"></svg>

  2. Run djlint test.html

Contents of .djlintrc/pyproject.toml [tool.djlint]

No config.
@kai687 kai687 added 🔍 linter 🦠 bug Something isn't working labels May 10, 2023
@welcome
Copy link

welcome bot commented May 10, 2023

Thanks for opening your first issue here!

christopherpickering pushed a commit that referenced this issue May 10, 2023
@semantic-release-bot
chore(release): 1.27.1 [skip ci]
073b0cb 
## [1.27.1](v1.27.0...v1.27.1) (2023-05-10)

### Bug Fixes

* **formatter:** fixed set_ tags being broken ([5cf1e1c](5cf1e1c)), closes [#634](#634)
* **linter:** fixed false positive on H037 ([e65558c](e65558c)), closes [#633](#633)
@christopherpickering
Copy link
Contributor

🎉 This issue has been resolved in version 1.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 linter 🦠 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kai687 @christopherpickering