-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile Fix #520
Compile Fix #520
Conversation
src/progress/pct/compile.p
Outdated
@@ -212,15 +212,33 @@ END PROCEDURE. | |||
PROCEDURE initModule: | |||
ASSIGN lIgnoredIncludes = (LENGTH(cignoredIncludes) > 0). | |||
|
|||
IF (callbackClass > "") AND NOT bAboveEq113 THEN | |||
IF (callbackClass > "") EQ TRUE AND NOT bAboveEq113 THEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DustinGrau-PSC What's that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should handle the case where callbackClass may somehow be the unknown value ? as well as an empty string. It ensures that the value is truly a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried with multiple values (?
, empty string, ...) and the eq true
is not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. It was more of a suggestion/habit when I use the > "" syntax for string checks.
Merci! Will there be a new release version created, or does that only occur when there are significant updates? |
v227 was released last week, so no, there won't be a new release soon. You can always download builds here: https://ci.rssw.eu/job/PCT/job/main/ |
Description
Adds additional error handling for creating the callback class for 11.3+ installations.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: