Fix JRebirth#156 The released-listener attached to the rootNode paren…

…t property is never removed
Rizen59 · Jul 28, 2015 · 512db65 · 512db65
1 parent 3e92a6e
commit 512db65
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/AbstractView.java b/org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/AbstractView.java
@@ -149,6 +149,7 @@ public void prepare() throws CoreException {
             public void changed(final ObservableValue<? extends Node> observable, final Node oldValue, final Node newValue) {
                 if (newValue == null) {
                     getModel().release();
+					getRootNode().parentProperty().removeListener(this);
                 }
             }
 

diff --git a/org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/fxml/AbstractFXMLObjectModel.java b/org.jrebirth.af/core/src/main/java/org/jrebirth/af/core/ui/fxml/AbstractFXMLObjectModel.java
@@ -119,6 +119,7 @@ protected final void initInternalModel() throws CoreException {
             public void changed(final ObservableValue<? extends Node> observable, final Node oldValue, final Node newValue) {
                 if (newValue == null) {
                     release();
+                    getRootNode().parentProperty().removeListener(this);
                 }
             }
 

diff --git a/...birth.af/core/src/main/java/org/jrebirth/af/core/ui/simple/AbstractSimpleObjectModel.java b/...birth.af/core/src/main/java/org/jrebirth/af/core/ui/simple/AbstractSimpleObjectModel.java
@@ -72,6 +72,7 @@ protected void initInternalModel() throws CoreException {
             public void changed(final ObservableValue<? extends Node> observable, final Node oldValue, final Node newValue) {
                 if (newValue == null) {
                     release();
+                    getRootNode().parentProperty().removeListener(this);
                 }
             }