Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y,Cb,Cr channels of the image? #18

Closed
asif-hanif opened this issue Nov 25, 2022 · 4 comments
Closed

Y,Cb,Cr channels of the image? #18

asif-hanif opened this issue Nov 25, 2022 · 4 comments

Comments

@asif-hanif
Copy link

Hi @RjDuan
Thank you for your work.

While creating components in following code, RGB channels of the images are being treated as YCbCr channels. If this observation is correct, could you please let me the reason behind re-naming RGB channels to YCbCr channels. Or someone should actually convert an image from RGB to YCbCr color space.

components = {'y': images[:,:,:,0], 'cb': images[:,:,:,1], 'cr': images[:,:,:,2]}

Thank you.

@RjDuan
Copy link
Owner

RjDuan commented Nov 26, 2022 via email

@asif-hanif
Copy link
Author

asif-hanif commented Nov 26, 2022

Thank you for the response. I get your point about significance of YCbCr color space.

My question is about the lines of code that are converting RGB to YCbCr color space. As far as I can see, RGB channels of the input images are not being converted to YCbCr in the code. Rather RGB channels are simply being considered YCbCr channels. Could you let me know the part of the code in the repo which is actually converting input batch of images from RGB to YCbCr color space in forward() of InfoDrop class.

Thank you.

@RjDuan
Copy link
Owner

RjDuan commented Nov 26, 2022 via email

@asif-hanif
Copy link
Author

Thanks @RjDuan for clarification.
My query has been addressed, so I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants