feat: Add reset button #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging issue_15 into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||
apomalyn
reviewed
Jul 1, 2024
| return InkWell( | ||
| onTap: () async { | ||
| avatarMakerController.restoreState(); | ||
| if (onTap != null) onTap!(); |
There was a problem hiding this comment.
Suggested change
| if (onTap != null) onTap!(); | |
| onTap?.call(); |
There was a problem hiding this comment.
This is more of a suggestion, depending on wether we use the same lint rules as Kana to kanji the linter will ask for it
|
Coverage after merging issue_15 into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||
Co-authored-by: Xavier Chrétien <chretienxavier42@gmail.com>
Co-authored-by: Xavier Chrétien <chretienxavier42@gmail.com>
|
Coverage after merging issue_15 into main will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||
apomalyn
approved these changes
Jul 2, 2024
| return InkWell( | ||
| onTap: () async { | ||
| avatarMakerController.restoreState(); | ||
| if (onTap != null) onTap!(); |
There was a problem hiding this comment.
This is more of a suggestion, depending on wether we use the same lint rules as Kana to kanji the linter will ask for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Add a reset button to make it easier for the users to reset the current customized avatar.
closes: #15
🖼️ Screenshots:
What the screenshot/video is presenting
2024-06-30.11-15-09.mp4
🧪 How to test the change?
☑️ Checklist before requesting a review
Please describe the checks you performed to verify your changes. Provide instructions so we can reproduce any specific checks to make sure things are working.
Tick the checkboxes to confirm if the checks were successful or not. (All that apply)
flutter runat the example project and it works without any issues.flutter analyzecompletes with "No issues found!"./CHANGELOG.md