-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floor and Ceiling Button Mixin crashes #390
Comments
Odd. Apparently this error happens if you |
I should probably stop being lazy and properly rewrite this mixin anyways. The overwrites were an incredibly fragile approach, some of these could be a simple inject at head. |
It turns out this can be easily fixed by adding an option to the mixin config json, which reduces the error to a warning. I pushed it because I don't see any downside, assuming you weren't intending to use overwrites to reduce visibility for some reason. It should fix any similar issues in other mixins even if you end up rewriting this one. |
I don't consider this a "fix" because theoretically it will silently break the mixin, if it breaks just one function that could produce potentially unwanted results. So imo this is still an issue. All that does is make the mixin silently fail, right? I'm in the process of rewriting it to properly use injectors, and heading to bed. Will be done tomorrow |
It doesn't break the mixin, it gets applied, only the visibility of the overwritten method won't match what you declared in the mixin class. The warning looks like this: |
Oh nice |
I use a translator application to post this issue.
This is a crash. Please upload, Pastebin, Gist or copypaste the whole crash report along with this issue.
This is a mod incompatibility. If I do this in vanilla Forge with only Et Futurum Requiem installed, it works normally.
Et-Futurum-Requiem 2.5.1 (crashed on 2.4.6 with same error before updating)
Game fails to start. No idea what mod is incompatible with EFR, the log just complains that it can't apply the floorcielbutton mixin from EFR. The only other mod the log mentions is COFHCore but removing it does nothing, the game fails to start with the same error. Disabling the floor and ceiling buttons option in the config allows the game to launch.
Mod list (Ignore the status letters before the mod this is from a seperate unrelated crash I caused to get the names of all the mods):
Log:
The text was updated successfully, but these errors were encountered: