Skip to content

Commit

Permalink
Merge pull request #45 from RoadieHQ/sc-16271-manually-remove-unused-…
Browse files Browse the repository at this point in the history
…dependency-to-satisfy-false-postive-security-scanners

Remove tough-cookie from the img
  • Loading branch information
Xantier committed Sep 4, 2023
2 parents bfa471f + 2032670 commit 5db0ce5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions dockerfiles/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ RUN npm install --global snyk-broker
RUN rm -rf /home/node/.npm-global/lib/node_modules/snyk-broker/node_modules/setheader/node_modules/debug


RUN rm -rf /home/node/.npm-global/lib/node_modules/snyk-broker/node_modules/tough-cookie
RUN npm i -g tough-cookie@4.1.3
RUN mv /home/node/.npm-global/lib/node_modules/tough-cookie /home/node/.npm-global/lib/node_modules/snyk-broker/node_modules

FROM roadiehq/broker:base
ENV PATH=$PATH:/home/node/.npm-global/bin
COPY --from=base /home/node/.npm-global /home/node/.npm-global
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node \
&& apt update && apt upgrade -y && apt install gpg curl xz-utils -y

ENV NODE_VERSION 18.16.1
ENV NODE_VERSION 18.17.1

RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
Expand Down

0 comments on commit 5db0ce5

Please sign in to comment.