Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to use multiple instances over proxy annotation #614

Merged
merged 1 commit into from
Aug 9, 2022
Merged

feat: add ability to use multiple instances over proxy annotation #614

merged 1 commit into from
Aug 9, 2022

Conversation

dweber019
Copy link
Contributor

Suggestion for issue #235

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@dweber019 dweber019 requested review from a team as code owners August 6, 2022 17:28
@roadie-bot
Copy link
Contributor

https://app.shortcut.com/larder/story/10054

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10054: feat: add ability to use multiple instances over proxy annotation.

@dweber019 dweber019 force-pushed the feat/prometheus-multiple-instances branch from 669e461 to 5b305b9 Compare August 6, 2022 17:36
@martina-if martina-if requested a review from Xantier August 8, 2022 07:49
Xantier
Xantier approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@Xantier Xantier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dweber019!

This looks like a straightforward approach to get this feature over the line. Merging.

@Xantier
Copy link
Contributor

Xantier commented Aug 9, 2022

Resolves #235

@Xantier Xantier merged commit 717c62d into RoadieHQ:main Aug 9, 2022
@dweber019 dweber019 deleted the feat/prometheus-multiple-instances branch August 9, 2022 07:55
@Xantier Xantier mentioned this pull request Sep 7, 2022
Closed
@bforbis bforbis mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xantier Xantier Xantier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dweber019 @roadie-bot @Xantier