Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minimizing to system tray #91

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Support minimizing to system tray #91

merged 4 commits into from
Jan 15, 2024

Conversation

DeSu0556
Copy link
Contributor

@DeSu0556 DeSu0556 commented Jan 9, 2024

#89 Support minimizing to the system tray, from which you can then reopen the ui

@DeSu0556
Copy link
Contributor Author

DeSu0556 commented Jan 9, 2024

Im really sorry. idea has initialized some code, which may cause the submission to be a bit messy.

@RoanH
Copy link
Owner

RoanH commented Jan 10, 2024

Hello, thank you for your contribution!

In general I think the implementation looks fine. It probably makes sense though to tie tray minimisation into the already existing command to hide the application (Ctrl + Y). I'm currently busy rewriting most of the internal logic to reduce the amount of technical debt in the project. After I'm done with that I'll get to this PR and then it'll most likely be included with the next release (towards the end of this week hopefully).

@RoanH
Copy link
Owner

RoanH commented Jan 15, 2024

I made some minor changes and tied the logic into the existing command to hide the application. If you're fine with those changes then I'll merge this.

Thanks again for the contribution! This is a really cool feature to have ^_^

@DeSu0556
Copy link
Contributor Author

I am also very honored to contribute to KPS! If I can help with other issues, I will do my best to help.

@RoanH RoanH merged commit 13988fa into RoanH:master Jan 15, 2024
1 check passed
@RoanH
Copy link
Owner

RoanH commented Jan 15, 2024

Awesome! You can find more open issues here if you want, though new ideas are also welcome of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants